This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(handleRef): handle null ref correctly
#487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
|
Should I add a record to |
Codecov Report
@@ Coverage Diff @@
## master #487 +/- ##
=======================================
Coverage 88.42% 88.42%
=======================================
Files 42 42
Lines 1451 1451
Branches 186 186
=======================================
Hits 1283 1283
Misses 163 163
Partials 5 5Continue to review full report at Codecov.
|
kuzhelov
approved these changes
Nov 19, 2018
layershifter
commented
Nov 19, 2018
There was a problem hiding this comment.
The easiest case if when we will try use cloneElement and try to catch a component's ref:
const htmlInput = <input />
// ----
cloneElement(htmlInput, {
ref: (node) => {
// 1. Calling existing handler
// A. We need to keep user's behaviour working, for example for 3rd party libs
// B. `ref` is not a prop in React, so when `ref` is not passed it's `null` by default
// and here it will fail without this fix
handleRef(child.ref, node)
// 2. Calling our handler
this.handleInputRef(node)
}
})So, this fix is for a handler ref, not for a value.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fix for the
handleRefref utility.There is a similar condition in React's code: https://github.com/facebook/react/blob/e58ecda9a2381735f2c326ee99a1ffa6486321ab/packages/react-reconciler/src/ReactFiberCommitWork.js#L625